On Saturday, January 26, 2013 10:39:53 PM Shawn Guo wrote: > Mark, > > On Fri, Jan 25, 2013 at 01:46:45PM -0600, Mark Langsdorf wrote: > > +static int hb_cpufreq_driver_init(void) > > +{ > > + struct device *cpu_dev; > > + struct clk *cpu_clk; > > + struct device_node *np; > > + int ret; > > + > > + for_each_child_of_node(of_find_node_by_path("/cpus"), np) > > + if (of_get_property(np, "operating-points", NULL)) > > + break; > > + > > + if (!np) { > > + pr_err("failed to find highbank cpufreq node\n"); > > + return -ENOENT; > > + } > > + > ... > > +out_put_node: > > + of_node_put(np); > > + return ret; > > +} > > +module_init(hb_cpufreq_driver_init); > > As we are moving to multiplatform build, this init function will run > on all other platforms built together with highbank. We should > probably eliminate that effect. That change can be made on top of the Mark's patches I think, right? If so, I'd prefer it that way. The Mark's patches have been in a limbo for too long already and that issue doesn't seem to be serious enough to block them any longer. Thanks, Rafael -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe cpufreq" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html