On Thu, Jan 10, 2013 at 02:15:44PM +0530, Viresh Kumar wrote:
...
> > + clk_prepare_enable(pll2_pfd2_396m_clk);
> > + clk_set_parent(step_clk, pll2_pfd2_396m_clk);
> > + clk_set_parent(pll1_sw_clk, step_clk);
> > + clk_prepare_enable(pll1_sys_clk);
>
> all these fns can fail too.. don't want to check return values?
>
I initially had every single clk and regulator call return checked
and error handled properly. But the code becomes very messy with
the error messages and recovering logic all over the places. I think
it's a bit over engineering, and made a compromise to only check limited
ones to ensure the correctness at subsystem level.
> > +static int imx6q_cpufreq_init(struct cpufreq_policy *policy)
> > +{
> > + int ret;
> > +
>
> So you finally removed the ugly check :)
>
I just found though it's less optimal, removing the check does not
really cause any problem for me.
> Reviewed-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
Thanks.
Shawn
--
To unsubscribe from this list: send the line "unsubscribe cpufreq" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
