On Wed, Sep 05, 2012 at 01:18:38AM +0200, Rafael J. Wysocki wrote: > On Friday, August 10, 2012, Shawn Guo wrote: > > It adds a generic cpufreq driver for CPU0 frequency management based on > > clk, regulator, OPP and device tree support. It can support both > > uniprocessor (UP) and those symmetric multiprocessor (SMP) systems which > > share clock and voltage across all CPUs. > > > > Signed-off-by: Shawn Guo <shawn.guo@xxxxxxxxxx> > > I seem to recall that this has been discussed with several people and > undergone some changes as a result of comments. Would it be possible > to get some ACKs from the people involved? > Mark, Santosh, Reviewed-by, please? AnilKumar, Tested-by, please? <snip> > > --- /dev/null > > +++ b/drivers/cpufreq/cpufreq-cpu0.c > > @@ -0,0 +1,271 @@ > > +/* > > + * Copyright (C) 2012 Freescale Semiconductor, Inc. > > + * > > + * Reuse some codes from drivers/cpufreq/omap-cpufreq.c > > What do you mean by "reuse" here? > cpu0_set_target() function is almost a copy of omap_target() from drivers/cpufreq/omap-cpufreq.c. I should probably just say so? > > + * > > + * The code contained herein is licensed under the GNU General Public > > + * License. You may obtain a copy of the GNU General Public License > > + * Version 2 or later at the following locations: > > The kernel is just GPLv2 (not later) and it will stay this way. Please > update this comment accordingly. > Okay. > > + * > > + * http://www.opensource.org/licenses/gpl-license.html > > + * http://www.gnu.org/copyleft/gpl.html > > + */ -- Regards, Shawn -- To unsubscribe from this list: send the line "unsubscribe cpufreq" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
