On Fri, Dec 16, 2011 at 06:30:59PM +0800, Richard Zhao wrote: > + if (higher && cpu_reg) > + regulator_set_voltage(cpu_reg, > + cpu_volts[index], cpu_volts[index]); > + > + ret = clk_set_rate(cpu_clk, freq); > + if (ret != 0) { > + printk(KERN_DEBUG "cannot set CPU clock rate\n"); > + return ret; > + } > + > + if (!higher && cpu_reg) > + regulator_set_voltage(cpu_reg, > + cpu_volts[index], cpu_volts[index]); This appears to reintroduce the setting of an exact voltage which I'm sure was fixed in previous versions of the patch. > +static struct cpufreq_driver arm_cpufreq_driver = { > + .flags = CPUFREQ_STICKY, > + .verify = arm_verify_speed, > + .target = arm_set_target, > + .get = arm_get_speed, > + .init = arm_cpufreq_init, > + .exit = arm_cpufreq_exit, > + .name = "arm", > +}; This code doesn't actually look terribly ARM specific... > + printk(KERN_INFO "ARM SoC generic CPU frequency driver\n"); Do we need this? -- To unsubscribe from this list: send the line "unsubscribe cpufreq" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html