RE: [PATCH] [CPUFREQ] S3C64xx: Notify transition complete as soon as frequency changed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Mark Brown wrote:
> 
> The CPUFREQ_POSTCHANGE notification is used to update things that depend
> on
> the system clock rates. Since this may include the interfaces used to talk
> to the regulators do the notification before we try to update regulators
> to reflect lowered system clock rate.
> 
> The voltage scaling is just a power optimisation and may not happen at all
> so there's no concern about it not having completed.
> 
> Signed-off-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>

Acked-by: Kukjin Kim <kgene.kim@xxxxxxxxxxx>

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

> ---
>  drivers/cpufreq/s3c64xx-cpufreq.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/cpufreq/s3c64xx-cpufreq.c
b/drivers/cpufreq/s3c64xx-cpufreq.c
> index c370935..b8d1d20 100644
> --- a/drivers/cpufreq/s3c64xx-cpufreq.c
> +++ b/drivers/cpufreq/s3c64xx-cpufreq.c
> @@ -114,6 +114,8 @@ static int s3c64xx_cpufreq_set_target(struct
> cpufreq_policy *policy,
>  		goto err;
>  	}
> 
> +	cpufreq_notify_transition(&freqs, CPUFREQ_POSTCHANGE);
> +
>  #ifdef CONFIG_REGULATOR
>  	if (vddarm && freqs.new < freqs.old) {
>  		ret = regulator_set_voltage(vddarm,
> @@ -127,8 +129,6 @@ static int s3c64xx_cpufreq_set_target(struct
> cpufreq_policy *policy,
>  	}
>  #endif
> 
> -	cpufreq_notify_transition(&freqs, CPUFREQ_POSTCHANGE);
> -
>  	pr_debug("cpufreq: Set actual frequency %lukHz\n",
>  		 clk_get_rate(armclk) / 1000);
> 
> --
> 1.7.5.4

--
To unsubscribe from this list: send the line "unsubscribe cpufreq" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Devel]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Forum]     [Linux SCSI]

  Powered by Linux