> > @@ -1112,6 +1114,9 @@ static int transition_frequency_pstate(struct powernow_k8_data *data, > > } > > > > res = transition_pstate(data, pstate); > > + if (res) > > + return res; > > That's wrong because transition_pstate() returns 0 unconditionally > (at least it does so on 3.0-rc3). But this change accidentally fixes > a different bug because res is used uninitialized, containing stack > garbage otherwise. > > A proper fix should be to check against data->max_hw_pstate and > check whether the entry is not CPUFREQ_ENTRY_INVALID (look at > fill_powernow_table_pstate() for example). Aha! I can respin a patch for that tomorrow. > > I'm guessing this oops happens when powernow-k8 is loaded in the guest > and that the actual power management is done in the hypervisor? Yes. -- To unsubscribe from this list: send the line "unsubscribe cpufreq" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
