On Wednesday 08 December 2010 17:39:14 Frank Arnold wrote:
> The cpufreq-aperf command does not work on 32-bit systems. The reason
> for that is a wrong count argument passed to the read() call. Instead
> of the buffer size, the size of the pointer to the buffer is used. On
> 64-bit systems this just happened to work, because we need to read an
> 8 byte value and a pointer has a size of 8 bytes on 64-bit. On 32-bit
> systems only 4 bytes are read, which then triggers the error path.
>
> Signed-off-by: Frank Arnold <frank.arnold@xxxxxxx>
> ---
> utils/aperf.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/utils/aperf.c b/utils/aperf.c
> index 1c64501..6302f5a 100644
> --- a/utils/aperf.c
> +++ b/utils/aperf.c
> @@ -100,7 +100,7 @@ static int read_msr(int cpu, unsigned int idx,
unsigned long long *val)
> return -1;
> if (lseek(fd, idx, SEEK_CUR) == -1)
> goto err;
> - if (read(fd, val, sizeof val) != sizeof *val)
> + if (read(fd, val, sizeof *val) != sizeof *val)
Reviewed-by: trenn@xxxxxxx
Thanks,
Thomas
--
To unsubscribe from this list: send the line "unsubscribe cpufreq" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
