Re: cpupowerutils: easier use of msr and cpuid stuff and some more

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday 05 October 2010 16:15:32 Dominik Brodowski wrote:
> Applied, thanks Thomas.
> 
> A few comments:
> - cpuid.h probably should be split up into a ".h" and a ".c" part
Yep, I agree.

> - Compiling msr.c:                                                      [OK]     
> 	  lib/msr.c:80: warning: âwrite_msrâ defined but not used
Hm, I think I would comment it out for now instead of deleting.
It will probably be needed soon.

> - instead of adding two options to cpufreq-info doing the same,
>   I only added one (--boost / -b) 
I agree.

I can send updates if you pushed them in.
That would be easier for me, instead of reworking/reposting.
On sever bugs/build failures, etc., I will of course repost.

Thanks,

   Thomas
--
To unsubscribe from this list: send the line "unsubscribe cpufreq" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Devel]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Forum]     [Linux SCSI]

  Powered by Linux