On Thu, Sep 30, 2010 at 10:43 PM, Davidlohr Bueso <dave@xxxxxxx> wrote: > x86, cpufreq: avoid an unnecessary double free when finished in pcc_cpufreq_do_osc() > > There is no need to fall through the out_free label thus saving a kfree call. > > Signed-off-by: Davidlohr Bueso <dave@xxxxxxx> > --- > arch/x86/kernel/cpu/cpufreq/pcc-cpufreq.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/arch/x86/kernel/cpu/cpufreq/pcc-cpufreq.c b/arch/x86/kernel/cpu/cpufreq/pcc-cpufreq.c > index 994230d..db7dc35 100644 > --- a/arch/x86/kernel/cpu/cpufreq/pcc-cpufreq.c > +++ b/arch/x86/kernel/cpu/cpufreq/pcc-cpufreq.c > @@ -379,6 +379,8 @@ static int __init pcc_cpufreq_do_osc(acpi_handle *handle) > if (!(supported & 0x1)) > return -ENODEV; > > + return ret; > + > out_free: > kfree(output.pointer); > return ret; Where is the double free here? I can't see it. I do see memory leaks happening in error handling paths of pcc_cpufreq_do_osc() which makes me think we need something like the attached patch.
Attachment:
0001-x86-cpufreq-Fix-pcc_cpufreq_do_osc-memory-leaks.patch
Description: Binary data
