Hello Thomas, On Wed, Aug 25, 2010 at 7:50 PM, Thomas Renninger <trenn@xxxxxxx> wrote: > Amit: Your problem seem not to be the 16 static freqs, oldfreqs, delta > arrays, but that only 6 frequencies max are displayed?: > > char cpufreqstrings[6][80]; > ... > if (maxfreq>4) > maxfreq=4; > which should limit the frequency information string to 6 lines. > This you should have to touch? I had seen the above logic. My aim is not to display all the P states. Am fine with top 4 (after sorting), how it currently does, and thus didn't suggest to change this in my patch. Though in some of the ARM boards the number of P states can be less than 4. Hence the display won't be nice for such boards. But, actually its the cpuidle states (C states), which bothers me more than the P states. The problem is that on some of the ARM boards the number of C states can be as many as 9 ! And different ARM SoC have different number of these C and P states. So, its not practical to have them hardcoded for each board! Hence, we need a way to dynamically find out the number of C and P states, and display accordingly. And the same code should ideally work on x86, ARM and any other architecture that may want to use powertop. > On the other hand side there already is sorting for most relevant/mostly > used frequencies and only these are cut out. So if you have 16 (or do > you really have more?) frequencies you should see the 6 mostly used > ones, which sounds sane -> display size is limited. As mentioned above, this is perfectly fine. The goal here is to have the same code function on x86 and various ARM SoCs - which have different levels of these C and P states. Thanks! Regards, Amit Arora -- To unsubscribe from this list: send the line "unsubscribe cpufreq" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
