On Fri, Jul 30, 2010 at 6:11 AM, Dominik Brodowski <linux@xxxxxxxxxxxxxxxxxxxx> wrote: > Hey, > > just a few minor comments: > > On Thu, Jul 29, 2010 at 05:29:30PM -0700, Colin Cross wrote: >> +int tegra_verify_speed(struct cpufreq_policy *policy) > static int Done >> +unsigned int tegra_getspeed(unsigned int cpu) > static unsined int Done >> + for_each_online_cpu(freqs.cpu) >> + cpufreq_notify_transition(&freqs, CPUFREQ_PRECHANGE); >> + >> +#ifdef CONFIG_CPU_FREQ_DEBUG >> + printk(KERN_DEBUG "cpufreq-tegra: transition: %u --> %u\n", >> + freqs.old, freqs.new); >> +#endif > What about using cpufreq_debug_printk(CPUFREQ_DEBUG_DRIVER, ... ) here? > >> + >> + ret = clk_set_rate_cansleep(cpu_clk, freqs.new * 1000); > "can sleep"? For how long? Adjusting the CPU clock may require changing the voltage through the regulator api, which locks a mutex, and eventually through I2C, which sleeps on I2C completion. -- To unsubscribe from this list: send the line "unsubscribe cpufreq" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
