Re: [PATCH 3/3] cpufrequtils aperf: Make data collection cpu hotplug proof

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hey,

On Thu, Apr 29, 2010 at 05:13:13PM +0200, Borislav Petkov wrote:
> > brodo@comet$ sudo ./cpufreq-aperf 
> > brodo@comet$ ./cpufreq-aperf 
> > 
> > We should abort if we can't read the MSR, not loop with reporting "all cores
> > are offline".
> 
> This shouldn't be happening actually, since you can't take cpu 0
> offline, IOW, it should be still showing CPU0 online.

No, it now reports a CPU to be offline even if the call to MSR fails for
other reasons.

> Right.
> If we cannot read MSR on CPU 0, something is wrong...

Well, the reason for this is only root can read this MSR, it seems. 

> Would you mind to add these already and I can send on top patches then.

Patches are applied, I just won't export them just yet.

Best,
	Dominik
--
To unsubscribe from this list: send the line "unsubscribe cpufreq" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Devel]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Forum]     [Linux SCSI]

  Powered by Linux