On Monday 22 March 2010 19:38:37 Borislav Petkov wrote: > From: Borislav Petkov <borislav.petkov@xxxxxxx> > > Multiple modules used to define those which are with identical > functionality and were needlessly replicated among the different cpufreq > drivers. Push them into the header and remove duplication. > ... > diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h > index 4de02b1..c8d731c 100644 > --- a/include/linux/cpufreq.h > +++ b/include/linux/cpufreq.h > @@ -278,6 +278,27 @@ struct freq_attr { > ssize_t (*store)(struct cpufreq_policy *, const char *, size_t count); > }; ... > > +#define define_one_global_ro(_name) \ > +static struct global_attr _name = \ > +__ATTR(_name, 0444, show_##_name, NULL) > + > +#define define_one_global_rw(_name) \ > +static struct global_attr _name = \ > +__ATTR(_name, 0644, show_##_name, store_##_name) These sound like too general names in global space. And are unrelated to cpufreq(.h). Eventually you get them into sysfs.h with another name or just duplicate them? Thomas -- To unsubscribe from this list: send the line "unsubscribe cpufreq" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html