Hey,
Thanks for the patches -- applied 1 to 4 already to my (local) git tree, but
I have question regarding the fifth one:
On Fri, Jan 15, 2010 at 03:02:08AM -0500, Mike Frysinger wrote:
> If we try to set a governor but get back an error, this might be due to the
> module not being loaded. So automatically run `modprobe` on the governor
> in question and retry the setting.
>
> Signed-off-by: Mike Frysinger <vapier@xxxxxxxxxx>
commit ea71497020c55cd39221e0abad5c1752ac6e3f47
Author: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Date: Thu Jul 6 12:32:01 2006 -0700
[CPUFREQ] [2/2] demand load governor modules.
Demand-load cpufreq governor modules if needed.
Signed-off-by: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Signed-off-by: Dave Jones <davej@xxxxxxxxxx>
does this for us in the kernel since 2.6.18 ... What do you think?
> ---
> lib/sysfs.c | 21 ++++++++++++++++++++-
> 1 files changed, 20 insertions(+), 1 deletions(-)
>
> diff --git a/lib/sysfs.c b/lib/sysfs.c
> index 4e0edab..c59058d 100644
> --- a/lib/sysfs.c
> +++ b/lib/sysfs.c
> @@ -12,6 +12,7 @@
> #include <limits.h>
> #include <sys/types.h>
> #include <sys/stat.h>
> +#include <sys/wait.h>
> #include <fcntl.h>
> #include <unistd.h>
>
> @@ -539,8 +540,23 @@ static int verify_gov(char *new_gov, char *passed_gov)
> return 0;
> }
>
> +static int modprobe(const char *module)
> +{
> + char new_module[strlen(module) + 10];
> + int status;
> + pid_t child;
> +
> + sprintf(new_module, "cpufreq_%s", module);
> + child = vfork();
> + if (child == 0)
> + _exit(execlp("modprobe", "modprobe", "-q", new_module, NULL));
> + waitpid(child, &status, 0);
> + return (WIFEXITED(status) && WEXITSTATUS(status) == 0 ? 0 : 1);
> +}
> +
> int sysfs_modify_policy_governor(unsigned int cpu, char *governor)
> {
> + int ret;
> char new_gov[SYSFS_PATH_MAX];
>
> if (!governor)
> @@ -549,7 +565,10 @@ int sysfs_modify_policy_governor(unsigned int cpu, char *governor)
> if (verify_gov(new_gov, governor))
> return -EINVAL;
>
> - return sysfs_write_one_value(cpu, WRITE_SCALING_GOVERNOR, new_gov, strlen(new_gov));
> + ret = sysfs_write_one_value(cpu, WRITE_SCALING_GOVERNOR, new_gov, strlen(new_gov));
> + if (ret == -ENODEV && modprobe(new_gov) == 0)
> + return sysfs_write_one_value(cpu, WRITE_SCALING_GOVERNOR, new_gov, strlen(new_gov));
> + return ret;
> };
>
> int sysfs_modify_policy_max(unsigned int cpu, unsigned long max_freq)
> --
> 1.6.6
>
> --
> To unsubscribe from this list: send the line "unsubscribe cpufreq" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe cpufreq" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
