Re: [PATCH -queue 3/3] [loongson] 2f: add Cpufreq support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hey,

On Wed, Nov 11, 2009 at 03:09:59PM +0800, Wu Zhangjin wrote:
> +	printk(KERN_INFO "cpufreq: Loongson-2F CPU frequency driver.\n");
> +	result = cpufreq_register_driver(&loongson2_cpufreq_driver);
> +
> +	if (!result && !nowait) {
> +		saved_cpu_wait = cpu_wait;
> +		cpu_wait = loongson2_cpu_wait;
> +	}
> +
> +	cpufreq_register_notifier(&loongson2_cpufreq_notifier_block,
> +				  CPUFREQ_TRANSITION_NOTIFIER);

IMO you should register the transition notifier before register_driver(),
else there's a small window where a change may be initiate which is not
notified...

Best,
	Dominik
--
To unsubscribe from this list: send the line "unsubscribe cpufreq" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Devel]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Forum]     [Linux SCSI]

  Powered by Linux