Re: [PATCH] acpi-cpufreq: blacklist Intel 0f68 processors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Matthew Garrett said the following on 08/10/2009 10:53 AM:
On Mon, Aug 10, 2009 at 10:48:30AM -0400, Prarit Bhargava wrote:
+static int acpi_cpufreq_blacklist(struct cpuinfo_x86 *c)
+{
+	/* http://www.intel.com/Assets/PDF/specupdate/314554.pdf
+	 * AL30 “A Machine Check Exception (MCE) Occurring during an
+	 * Enhanced Intel SpeedStep® Technology Ratio Change May Cause
+	 * Both Processor Cores to Lock Up */
+		if (c->x86_vendor == X86_VENDOR_INTEL) {

Whitespace looks off here. We may want a more generic implementation
with an extendable structure, but in the absence of any other known
fixups this seems fine to me.

Since this is a rare case, should a log message be generated, so people understand why their processor is not working with acpi-cpufreq?

--
John Villalovos
Intel Corporation on-site partner engineer at Red Hat, Inc.

http://tabasco.usersys.redhat.com/
--
To unsubscribe from this list: send the line "unsubscribe cpufreq" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Devel]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Forum]     [Linux SCSI]

  Powered by Linux