Dave Jones wrote: > On Fri, Jul 10, 2009 at 03:25:11PM -0400, Dave Jones wrote: > > > [PATCH] Add suspend method to cpufreq core > > > > In order to properly fix some issues with cpufreq vs. sleep on > > PowerBooks, I had to add a suspend callback to the pmac_cpufreq driver. > > I must force a switch to full speed before sleep and I switch back to > > previous speed on resume. > > > > > > Ben, is there something better we can do here ? > > > > I really don't want to add an #ifdef __powerpc__ to core code if we can help it. > > I'd rather we didn't call into driver guts at all from the suspend path. > > Marcin, > Unless we get a better solution proposed, try running with this, which just > skips doing all that code entirely. Now it produces only: powernow-k8: error - out of sync, fix 0x2 0xc, vid 0x12 0x6 (arch/x86/kernel/cpu/cpufreq/powernow-k8.c: powernowk8_target) but works fine. If it's nothing to worry about, you can add: Tested-by: Marcin Slusarz <marcin.slusarz@xxxxxxxxx> Thanks, Marcin -- To unsubscribe from this list: send the line "unsubscribe cpufreq" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html