On Wed, Jul 08, 2009 at 11:08:12AM -0700, Linus Torvalds wrote: > ... > Also, that whole function could damn well be split into smaller pieces, > which would make it much more readable than that horrible 250+ line piece > of crap monster-function with #ifdef's inside the code. > > Please, somebody? I took a quick stab at this, and factored out cpufreq_add_dev into three separate functions. I just pushed it out to the 'next' branch of cpufreq.git It could use someone else looking it over, just to be sure I got all the nest of error paths handled correctly. It's still not the prettiest code, but it's at least getting clearer.. Note: I've not boot-tested this stuff at all yet. Dave -- To unsubscribe from this list: send the line "unsubscribe cpufreq" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html