Re: [PATCH 2/6] cpumask: avoid playing with cpus_allowed in speedstep-ich.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 11, 2009 at 10:59:58PM +0930, Rusty Russell wrote:


Minor nit (and this was there before your change, but because
you moved it, checkpatch now whines..)

 > +static void get_freqs_on_cpu(void *_get_freqs)
 > +{
 > +	struct get_freqs *get_freqs = _get_freqs;
 > +
 > +	get_freqs->ret =
 > +		speedstep_get_freqs(speedstep_processor,
 > +				    &speedstep_freqs[SPEEDSTEP_LOW].frequency,
 > +				    &speedstep_freqs[SPEEDSTEP_HIGH].frequency,
 > +				    &get_freqs->policy->cpuinfo.transition_latency,
 > +				    &speedstep_set_state);
 > +}

line over 80 characters. 
I'll just pull it back one tab.

Perhaps some variable renaming in this file is called for to reduce
some of the redundancy in such lines.

	Dave

--
To unsubscribe from this list: send the line "unsubscribe cpufreq" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Devel]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Forum]     [Linux SCSI]

  Powered by Linux