Hi,
On Friday 06 March 2009 21:22:45 Jarod Wilson wrote:
> Some atom procs don't do freq scaling (such as the atom 330 on my own
> littlefalls2 board). By adding the atom family here, we at least get
> the benefit of passive cooling in a thermal emergency.
> Not sure how to see that its actually helping any,
> but the driver does bind and
> claim its functioning on my atom 330.
I do not think this is a good idea.
There was a patch posted for a eeepc specific cpufreq enhancement
making use of some "not official" ACPI methods.
Re: [PATCH 1/1] cpufreq: eeepc 900 frequency scaling driver
There existed two version, one of Tom Hughes integrating the cpufreq
parts into the already existing eeepc driver and one of Cristiano
Prisciandaro providing a separate eeepc cpufreq driver.
Now we have three unsynchronized instances doing clock modulation:
- as specified by ACPI spec
- through unspecified ACPI functions (e.g. on eeepc, fortunately
only on a specific set of machines)
- natively via p4_clockmod
The eeepc driver has not been pushed yet, as far as I can tell, but
Matthew and Pavel already went through the code and did not object.
I wonder what happens if you load the p4_clockmod and eeepc driver
both doing more or less the same.
Thomas
> Signed-off-by: Jarod Wilson <jarod@xxxxxxxxxx>
>
> ---
>
> arch/x86/kernel/cpu/cpufreq/p4-clockmod.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/x86/kernel/cpu/cpufreq/p4-clockmod.c
b/arch/x86/kernel/cpu/cpufreq/p4-clockmod.c
> index 352cf9a..f96d8b6 100644
> --- a/arch/x86/kernel/cpu/cpufreq/p4-clockmod.c
> +++ b/arch/x86/kernel/cpu/cpufreq/p4-clockmod.c
> @@ -168,6 +168,7 @@ static unsigned int cpufreq_p4_get_frequency(struct
cpuinfo_x86 *c)
> case 0x0E: /* Core */
> case 0x0F: /* Core Duo */
> case 0x16: /* Celeron Core */
> + case 0x1C: /* Atom */
> p4clockmod_driver.flags |= CPUFREQ_CONST_LOOPS;
> return speedstep_get_frequency(SPEEDSTEP_CPU_PCORE);
> case 0x0D: /* Pentium M (Dothan) */
>
--
To unsubscribe from this list: send the line "unsubscribe cpufreq" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
