[Bug 12826] cpufreq driver do not expose all data and configuration to /sys

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



http://bugzilla.kernel.org/show_bug.cgi?id=12826





------- Comment #11 from anonymous@xxxxxxxxxxxxxxxxxxxx  2009-03-06 19:31 -------
Reply-To: akpm@xxxxxxxxxxxxxxxxxxxx

On Sat, 7 Mar 2009 03:16:29 +0000 Matthew Garrett <mjg@xxxxxxxxxx> wrote:

> > The userspace interface to this driver changed in an incompatible
> > fashion.  This can lead to failure (and hence premature termination) of
> > userspace configuration scripts and in this case (at least) it has led
> > to CPU overheating.
> 
> Every single case of userspace using this interface is a bug. It's 
> either wasting power or unnecessarily reducing performance.

I repeat:

  The userspace interface to this driver changed in an incompatible
  fashion.  This can lead to failure (and hence premature termination)
  of userspace configuration scripts and in this case (at least) it has
  led to CPU overheating.

I can promise you that if the changelog to
e088e4c9cdb618675874becb91b2fd581ee707e6 had included the text "this
patch will break existing scripts and will lead to CPU overheating"
then it would not have been applied.

Look, there are better ways of fixing things like this.  Revert the
patch, add some noisy printks (triggered by use of the sysfs interface)
telling people that they are doing the wrong thing and telling them how
to fix it.  After 6-9 months, then we can make the kernel interface
change.

We shouldn't just rip the thing out without any warning and break
stuff.


-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
--
To unsubscribe from this list: send the line "unsubscribe cpufreq" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Devel]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Forum]     [Linux SCSI]

  Powered by Linux