On Fri, 16 Jan 2009 11:11:10 -0800 Mike Travis <travis@xxxxxxx> wrote:
> From: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
>
> Impact: remove potential clashes with generic kevent workqueue
>
> Annoyingly, some places we want to use work_on_cpu are already in
> workqueues. As per Ingo's suggestion, we create a different workqueue
> for work_on_cpu.
>
> Signed-off-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
> Signed-off-by: Mike Travis <travis@xxxxxxx>
> ---
> kernel/workqueue.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> --- linux-2.6-for-ingo.orig/kernel/workqueue.c
> +++ linux-2.6-for-ingo/kernel/workqueue.c
> @@ -971,6 +971,8 @@ undo:
> }
>
> #ifdef CONFIG_SMP
> +static struct workqueue_struct *work_on_cpu_wq __read_mostly;
Pity the poor reader who comes along trying to work out why this exists.
> struct work_for_cpu {
> struct work_struct work;
> long (*fn)(void *);
> @@ -1001,7 +1003,7 @@ long work_on_cpu(unsigned int cpu, long
> INIT_WORK(&wfc.work, do_work_for_cpu);
> wfc.fn = fn;
> wfc.arg = arg;
> - schedule_work_on(cpu, &wfc.work);
> + queue_work_on(cpu, work_on_cpu_wq, &wfc.work);
> flush_work(&wfc.work);
>
> return wfc.ret;
> @@ -1019,4 +1021,8 @@ void __init init_workqueues(void)
> hotcpu_notifier(workqueue_cpu_callback, 0);
> keventd_wq = create_workqueue("events");
> BUG_ON(!keventd_wq);
> +#ifdef CONFIG_SMP
> + work_on_cpu_wq = create_workqueue("work_on_cpu");
> + BUG_ON(!work_on_cpu_wq);
> +#endif
Yet another kernel thread for each CPU. All because of some dung way
down in arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c.
Is there no other way?
--
To unsubscribe from this list: send the line "unsubscribe cpufreq" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
