On Wednesday 27 August 2008 18:39:52 Jarod Wilson wrote: > On Wednesday 27 August 2008 11:44:02 Thomas Renninger wrote: > > The idea is to add this to printk after the severity: > > printk(KERN_ERR FW_BUG "This is not our fault\n"); > > > > If a Firmware issue should be hidden, because it is > > work-arounded, but you still want to see something popping up e.g. > > for info only: > > printk(KERN_INFO FW_INFO "This is done stupid, we can handle it, > > but it should better be avoided in future\n"); > > > > or on the Linuxfirmwarekit to tell vendors that they did something > > stupid or wrong without bothering the user: > > printk(KERN_INFO FW_BUG "This is done stupid, we can handle it, > > but it should better be avoided in future\n"); > > > > Signed-off-by: Thomas Renninger <trenn@xxxxxxx> > > --- > > include/linux/kernel.h | 3 +++ > > 1 files changed, 3 insertions(+), 0 deletions(-) > > > > diff --git a/include/linux/kernel.h b/include/linux/kernel.h > > index 2651f80..68ebfc2 100644 > > --- a/include/linux/kernel.h > > +++ b/include/linux/kernel.h > > @@ -190,6 +190,9 @@ extern int kernel_text_address(unsigned long addr); > > struct pid; > > extern struct pid *session_of_pgrp(struct pid *pgrp); > > > > +#define FW_BUG "[FW Bug]: " > > +#define FW_INFO "[FW Info]: " > > + > > #ifdef CONFIG_PRINTK > > asmlinkage int vprintk(const char *fmt, va_list args) > > __attribute__ ((format (printf, 1, 0))); > > In firewire-land, we were strongly advised against abbreviating things with > 'fw', ... right, I also thought about this shortly. [Firmware Info] looked that long... Andrew, you might still want to modify the patch in place (no line added/deleted) to: > > +#define FW_BUG "[Firmware Bug]: " > > +#define FW_INFO "[Firmware Info]: " if you think it's appropriate. Thanks, Thomas -- To unsubscribe from this list: send the line "unsubscribe cpufreq" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
