On 20/03/15 10:26, Jan Friesse wrote: > Chrissie, > nice idea but I have two comments. > 1. Nodes without nodeid (so auto generated nodeid) are not checked. It > can happen that user enters nodeid which collides with auto generated > nodeid. In practice not very important, but still make sense to make it > right. Good point, I'll look into this. > 2. We don't have mechanism to exit corosync on reload but during startup > it may make sense to simply exit corosync if there are nodes with > duplicate nodeids. It's evidently mistake and people tends to NOT read > logs. > It does exit if there is a duplicate nodeid in corosync.conf, the only information that is inthe logs only is if there is more than 1 duplicate nodeid. Corosync will still fail to start and show 1 duplicate, the other will me in syslog Chrissie > Regards, > Honza > > Christine Caulfield napsal(a): >> Having duplicate nodeids in corosync.conf can play havoc with a cluster, >> so (as suggested by someone on this list) here is some code to check >> that all nodeids are unique. >> >> It logs all non-unique nodeids to syslog, but only the last is reported >> on the command-line to the user which should be enough to get them to >> check further. >> >> Signed-off-by: Christine Caulfield <ccaulfie@xxxxxxxxxx> >> >> >> >> _______________________________________________ >> discuss mailing list >> discuss@xxxxxxxxxxxx >> http://lists.corosync.org/mailman/listinfo/discuss >> > _______________________________________________ discuss mailing list discuss@xxxxxxxxxxxx http://lists.corosync.org/mailman/listinfo/discuss
