Chrissie, Christine Caulfield napsal(a): > On 05/03/15 13:42, Jan Friesse wrote: >> Chrissie, >> patch looks generally good. Can you please fix indentation so: >> - Allocate a buffer to contain a full message. comment is not aligned >> - cpg_inst_copy.model_v1_data.cpg_deliver_fn (handle, &group_name, ... >> looks like 6 tabs + 8 spaces on first line and 19 tabs on second and >> following lines >> - iov[1].iov_len = iovec[i].iov_len - iov_sent is aligned with 4 spaces >> instead of one tab >> ? >> >> Also (and this is bigger problem) I'm not entirely happy with: >> >> usleep(10000); >> goto resend; >> >> part. I mean, yes it make sense, on the other hand, it may cause app to >> block potentially forever. What do you thing about limited number of >> retries? >> >> Last thing is cpghum_LDADD. I'm not entirely sure if libz is really >> dependency on some library corosync is using. If so, we don't >> necessarily need to check it's presence, but if not, we have to check it >> in configure script... Actually, it would be nice to test it anyway. >> > > > I've checked all the indentation, and fixed my .emacs file so it should > remain sane from now on, I hope. Here's a revised patch with fixed > indentation, a retry count in send (value determined empirically with > slow VMs and large, 8M, messages) and a test for libz in configure > (which doesn't seem to be used elsewhere) indentation looks perfect, thanks. I have last small nitpick and it's about adding build require for zlib-devel to corosync.spec.in. Other then that, it's ACK. Thanks, Honza > > Signed-Off-By: Christine Caulfield <ccaulfie@xxxxxxxxxx> > > > Chrissie > > > _______________________________________________ discuss mailing list discuss@xxxxxxxxxxxx http://lists.corosync.org/mailman/listinfo/discuss
