On 4/17/2013 5:26 PM, José Orlando Pereira wrote: > On Wednesday 17 April 2013 16:47:29 Fabio M. Di Nitto wrote: >> On 4/17/2013 3:52 PM, José Orlando Pereira wrote: >>> The large stack size in cpg_dispatch, resulting from the >>> message buffer, is causing a segmentation fault in environments >>> with a constrained stack size, namely, when calling into >>> cpg_dispatch from Java using JNI (i.e. for >>> http://github.com/jopereira/jgcs/tree/master/jgcs-corosync). >> >> style: char *dispatch_buf = NULL; >> >> if (dispatch_buf == NULL) { >> .... return appropriate error .... >> } >> >> and you will need to repeat this patch for all libraries. > > Please find revised patch below. Note that I have not tested other libs, as I am > using just CPG. But I checked that there are no early returns that would leak. The patch is better. Did you verify the performance impact of switching from static to malloc? there is a test/cpgbench you can use. Fabio _______________________________________________ discuss mailing list discuss@xxxxxxxxxxxx http://lists.corosync.org/mailman/listinfo/discuss
