Andrei,
thanks for patch. ACK, and I've pushed to master.
Regards,
Honza
Andrei Belov napsal(a):
>
> On Mar 28, 2013, at 17:01 , Jan Friesse <jfriesse@xxxxxxxxxx> wrote:
>
>> Andrei,
>> thanks for patch. Sadly, this part was changed in
>> 52f88d04eaf2ad6c65df34a3401417d0583c6a45 (and I believe error you are
>> pointing out is still existing there). Can you please send a patch
>> applied on master git version?
>
> Sure, please find it attached.
>
> By the way, current code seems to be incorrect: using errno
> with getpwnam_r()/getgrnam_r() functions is meaningless
> (patch fixed this also).
>
>
>>
>> Thanks,
>> Honza
>>
>> Andrei Belov napsal(a):
>>> Hello corosync users,
>>>
>>> I've spent some time building and trying corosync 2.3.0 on SunOS
>>> (Joyent's SmartOS-based VM), and noticed one issue with uidgid {}
>>> configuration blocks parsing, e.g.:
>>>
>>> uidgid {
>>> uid: user|uid
>>> gid: group|gid
>>> }
>>>
>>> Corosync won't display any errors in case of non-existent username/uid
>>> or groupname/gid in configuration, and then we'll get something like
>>> that:
>>>
>>> # corosync-cmapctl uidgid
>>> uidgid.gid.4096 (u8) = 1
>>> uidgid.uid.4292862832 (u8) = 1
>>>
>>> I'm attaching the patch that fixes this issue by performing additional
>>> checks according to the following POSIX documents:
>>>
>>> http://pubs.opengroup.org/onlinepubs/9699919799/functions/getpwnam_r.html
>>> http://pubs.opengroup.org/onlinepubs/9699919799/functions/getgrnam_r.html
>>>
>>> [..]
>>> A null pointer is returned at the location pointed to by result on error or if the requested entry is not found.
>>> [..]
>>>
>>>
>>> Hope this would be helpful for someone.
>>>
>>> Best regards,
>>> Andrei.
>
>
_______________________________________________
discuss mailing list
discuss@xxxxxxxxxxxx
http://lists.corosync.org/mailman/listinfo/discuss
