Re: Coroipcc_dispath_get assert

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,
honestly I'm really unsure why this assert is there. Actually, it really
looks like thing which shouldn't be there at all. I would suggest a
patch, which simply:
- remove whole #if defined (as it doesn't seem to be needed)
- remove assert
- check if error is CS_OK and if not, goto error_put

Regards,
  Honza

jason napsal(a):
> Hi All,
> We have encountered an assertion at coroipc.c:925 and it seems hard to
> reproduce. According to the code of corosync-1.4.4 it means socket_recv()
> did not return CS_OK as expected by coroipcc_dispatch_get(). But I checked
> socket_recv() and found that it DO return CS_ERR_TRY_AGAIN or
> CS_ERR_LIBRARY in some cases. So does it really need this assertion  or do
> we need to deal with ! CS_OK cases at coroipc.c:925?
> 
> Thank you!
> 
> 
> 
> _______________________________________________
> discuss mailing list
> discuss@xxxxxxxxxxxx
> http://lists.corosync.org/mailman/listinfo/discuss
> 

_______________________________________________
discuss mailing list
discuss@xxxxxxxxxxxx
http://lists.corosync.org/mailman/listinfo/discuss


[Index of Archives]     [Linux Clusters]     [Corosync Project]     [Linux USB Devel]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Linux Kernel]     [Linux SCSI]     [X.Org]

  Powered by Linux