Re: [PATCH 2/3] Handle segfault in backlog_get

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



ACK

On 11/8/2012 4:08 PM, Jan Friesse wrote:
> If instance->memb_state is not OPERATION or RECOVERY, we was passing NULL
> to cs_queue_used call.
> 
> Signed-off-by: Jan Friesse <jfriesse@xxxxxxxxxx>
> ---
>  exec/totemsrp.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/exec/totemsrp.c b/exec/totemsrp.c
> index b0a0560..7fcee9b 100644
> --- a/exec/totemsrp.c
> +++ b/exec/totemsrp.c
> @@ -3414,7 +3414,10 @@ static unsigned int backlog_get (struct totemsrp_instance *instance)
>  	if (instance->memb_state == MEMB_STATE_RECOVERY) {
>  		queue_use = &instance->retrans_message_queue;
>  	}
> -	backlog = cs_queue_used (queue_use);
> +
> +	if (queue_use != NULL) {
> +		backlog = cs_queue_used (queue_use);
> +	}
>  
>  	instance->stats.token[instance->stats.latest_token].backlog_calc = backlog;
>  	return (backlog);
> 

_______________________________________________
discuss mailing list
discuss@xxxxxxxxxxxx
http://lists.corosync.org/mailman/listinfo/discuss


[Index of Archives]     [Linux Clusters]     [Corosync Project]     [Linux USB Devel]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Linux Kernel]     [Linux SCSI]     [X.Org]

  Powered by Linux