Re: [PATCH 4/5] Use uint8_t in setsockopt when needed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Are you sure these are 8 bits?

Reviewed-by: Steven Dake <sdake@xxxxxxxxxx>

On 08/31/2012 01:47 AM, Jan Friesse wrote:
> ---
>  exec/totemudp.c |    7 +++++--
>  1 files changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/exec/totemudp.c b/exec/totemudp.c
> index 5ad3fc8..de2d467 100644
> --- a/exec/totemudp.c
> +++ b/exec/totemudp.c
> @@ -682,6 +682,7 @@ static int totemudp_build_sockets_ip (
>  	int addrlen;
>  	int res;
>  	int flag;
> +	uint8_t sflag;
>  
>  	/*
>  	 * Create multicast recv socket
> @@ -878,8 +879,9 @@ static int totemudp_build_sockets_ip (
>  	flag = 1;
>  	switch ( bindnet_address->family ) {
>  		case AF_INET:
> +		sflag = 1;
>  		res = setsockopt (sockets->mcast_send, IPPROTO_IP, IP_MULTICAST_LOOP,
> -			&flag, sizeof (flag));
> +			&sflag, sizeof (sflag));
>  		break;
>  		case AF_INET6:
>  		res = setsockopt (sockets->mcast_send, IPPROTO_IPV6, IPV6_MULTICAST_LOOP,
> @@ -904,8 +906,9 @@ static int totemudp_build_sockets_ip (
>  			return (-1);
>  		}
>  	} else {
> +		sflag = flag;
>  		res = setsockopt(sockets->mcast_send, IPPROTO_IP, IP_MULTICAST_TTL,
> -			&flag, sizeof(flag));
> +			&sflag, sizeof(sflag));
>  		if (res == -1) {
>  			LOGSYS_PERROR (errno, instance->totemudp_log_level_warning,
>  				"set mcast v4 TTL failed");
> 

_______________________________________________
discuss mailing list
discuss@xxxxxxxxxxxx
http://lists.corosync.org/mailman/listinfo/discuss


[Index of Archives]     [Linux Clusters]     [Corosync Project]     [Linux USB Devel]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Linux Kernel]     [Linux SCSI]     [X.Org]

  Powered by Linux