Re: [PATCH][flatiron] confdb: Fix crash with long values and add API calls to get them

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



ACK + pushed

Thanks,
  Honza

Christine Caulfield napsal(a):
.. and forget that last one. This one passes valgrind

Signed-Off-By: Christine Caulfield <ccaulfie@xxxxxxxxxx>



On 13/08/12 09:31, Christine Caulfield wrote:
I just found a large memory leak in that patch. This patch fixes it.
I'll add it to the BZ

Signed-Off-By: Christine Caulfield <ccaulfie@xxxxxxxxxx>



On 10/08/12 09:14, Fabio M. Di Nitto wrote:
Patch looks good to me.

ACK

Fabio

On 8/10/2012 10:00 AM, Christine Caulfield wrote:
confdb as it stands has a limit of 256 bytes in a returned value -
anything larger than that will cause corosync to crash.

This patch adds checks toprevent this happening, fixes some API calls
so that they return the full value and adds some new ones where it
wasn't possible to safely return am arbitrarily long string.

It refers to Red Hat Bugzilla #845626

include/corosync/confdb.h | 18 +++
include/corosync/ipc_confdb.h | 54 +++++++++
lib/confdb.c | 232
+++++++++++++++++++++++++++++++++++++-----
lib/sa-confdb.c | 33 ++++-
lib/sa-confdb.h | 6 -
services/confdb.c | 215
++++++++++++++++++++++++++++++++++----
tools/corosync-objctl.c | 27 +++-
7 files changed, 514 insertions(+), 71 deletions(-)

Signed-Off-By: Christine Caulfield <ccaulfie@xxxxxxxxxx>




_______________________________________________
discuss mailing list
discuss@xxxxxxxxxxxx
http://lists.corosync.org/mailman/listinfo/discuss

_______________________________________________
discuss mailing list
discuss@xxxxxxxxxxxx
http://lists.corosync.org/mailman/listinfo/discuss


[Index of Archives]     [Linux Clusters]     [Corosync Project]     [Linux USB Devel]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Linux Kernel]     [Linux SCSI]     [X.Org]

  Powered by Linux