On Fri, Aug 10, 2012 at 7:02 PM, Jan Friesse <jfriesse@xxxxxxxxxx> wrote:
> I'm not saying that your arguments doesn't make sense, on the other hand,
> logsys in corosync/openais used to have threaded logging for AGES. I believe
> this had reason.
Sure. Just putting it out there for thought.
>
> Also I hope syslog will NOT just start dropping messages.
>From what I've seen on fedora, it does at least let you know.
> I know rsyslogd
> has this ability and this can be turned off.
>
> So if somebody is running ether syslog without rate limit OR for example log
> files on disconnected NFS share, corosync would block and I believe this is
> not what we want.
Anyone logging to NFS needs to be shot :-)
>
> Honza
>
> Andrew Beekhof napsal(a):
>>
>> As someone that uses libqb to log a metric buttload to files and
>> syslogs on a regular basis... I have to ask "why?".
>>
>> Even prior to libqb, I've never seen anything that would suggest a
>> process was blocked waiting for syslog or a file (and thats with 5 or
>> more processes logging to the same place).
>> Syslog will just start dropping messages if you log too much, so I'm
>> inclined to say you're solving a theoretical problem :)
>>
>> Something to think about.
>>
>> On Fri, Aug 10, 2012 at 1:27 AM, Jan Friesse<jfriesse@xxxxxxxxxx> wrote:
>>>
>>> Syslog and file log can block, so it's good idea to use libqb threaded
>>> mode to prevent it.
>>>
>>> Signed-off-by: Jan Friesse<jfriesse@xxxxxxxxxx>
>>> ---
>>> exec/logsys.c | 2 ++
>>> 1 files changed, 2 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/exec/logsys.c b/exec/logsys.c
>>> index 6ed5c4f..ed16bc7 100644
>>> --- a/exec/logsys.c
>>> +++ b/exec/logsys.c
>>> @@ -230,6 +230,7 @@ static int logsys_config_file_set_unlocked (
>>> qb_log_ctl(logsys_loggers[subsysid].target_id,
>>> QB_LOG_CONF_ENABLED,
>>> (logsys_loggers[subsysid].mode&
>>> LOGSYS_MODE_OUTPUT_FILE));
>>>
>>> + qb_log_ctl(logsys_loggers[subsysid].target_id,
>>> QB_LOG_CONF_THREADED, QB_TRUE);
>>>
>>> return (0);
>>> }
>>> @@ -355,6 +356,7 @@ int _logsys_system_setup(
>>> } else {
>>> qb_log_ctl(QB_LOG_SYSLOG, QB_LOG_CONF_ENABLED,
>>> QB_FALSE);
>>> }
>>> + qb_log_ctl(QB_LOG_SYSLOG, QB_LOG_CONF_THREADED, QB_TRUE);
>>> qb_log_ctl(QB_LOG_SYSLOG, QB_LOG_CONF_PRIORITY_BUMP, LOG_INFO -
>>> LOG_DEBUG);
>>>
>>> qb_log_filter_ctl(QB_LOG_BLACKBOX, QB_LOG_FILTER_ADD,
>>> --
>>> 1.7.1
>>>
>>> _______________________________________________
>>> discuss mailing list
>>> discuss@xxxxxxxxxxxx
>>> http://lists.corosync.org/mailman/listinfo/discuss
>
>
_______________________________________________
discuss mailing list
discuss@xxxxxxxxxxxx
http://lists.corosync.org/mailman/listinfo/discuss
