Re: [PATCH 1/2] totemip: insert items in correct order

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/23/2012 06:23 AM, Jan Friesse wrote:
> list_add_tail is used instead of list_add so ip addresses are inserted
> in same order as returned by getifaddrs.
> 
> Signed-off-by: Jan Friesse <jfriesse@xxxxxxxxxx>
> ---
>  exec/totemip.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/exec/totemip.c b/exec/totemip.c
> index 90c8f77..96f38b0 100644
> --- a/exec/totemip.c
> +++ b/exec/totemip.c
> @@ -384,7 +384,7 @@ int totemip_getifaddrs(struct list_head *addrs)
>  			goto error_free_addr_name;
>  		}
>  
> -		list_add(&if_addr->list, addrs);
> +		list_add_tail(&if_addr->list, addrs);
>  	}
>  
>  	freeifaddrs(ifap);
> @@ -484,7 +484,7 @@ int totemip_getifaddrs(struct list_head *addrs)
>  				if_addr->interface_num = lifreq[i].lifr_index;
>  			}
>  
> -			list_add(&if_addr->list, addrs);
> +			list_add_tail(&if_addr->list, addrs);
>  		}
>  
>  		free (lifconf.lifc_buf);


Reviewed-by: Steven Dake <sdake@xxxxxxxxxx>
_______________________________________________
discuss mailing list
discuss@xxxxxxxxxxxx
http://lists.corosync.org/mailman/listinfo/discuss


[Index of Archives]     [Linux Clusters]     [Corosync Project]     [Linux USB Devel]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Linux Kernel]     [Linux SCSI]     [X.Org]

  Powered by Linux