[PATCH] totem: don't send garbage onwire if we fail to crypt

["Fabio M. Di Nitto" <fdinitto@xxxxxxxxxx>]

From: "Fabio M. Di Nitto" <fdinitto@xxxxxxxxxx>

Signed-off-by: Fabio M. Di Nitto <fdinitto@xxxxxxxxxx>
---
 exec/totemudp.c  |   12 ++++--------
 exec/totemudpu.c |   12 ++++--------
 2 files changed, 8 insertions(+), 16 deletions(-)

diff --git a/exec/totemudp.c b/exec/totemudp.c
index 9f3acb9..e265732 100644
--- a/exec/totemudp.c
+++ b/exec/totemudp.c
@@ -268,10 +268,8 @@ static inline void ucast_sendmsg (
 		msg_len,
 		buf_out,
 		&buf_out_len) != 0) {
-		/*
-		 * TODO: how to handle error here
-		 */
-		log_printf(LOGSYS_LEVEL_CRIT, "Unable to crypt? now what?");
+		log_printf(LOGSYS_LEVEL_CRIT, "Error encrypting/signing packet (non-critical)");
+		return;
 	}
 
 	iovec.iov_base = (void *)buf_out;
@@ -330,10 +328,8 @@ static inline void mcast_sendmsg (
 		msg_len,
 		buf_out,
 		&buf_out_len) != 0) {
-		/*
-		 * TODO: how to handle error here
-		 */
-		log_printf(LOGSYS_LEVEL_CRIT, "unable to crypt? now what?");
+		log_printf(LOGSYS_LEVEL_CRIT, "Error encrypting/signing packet (non-critical)");
+		return;
 	}
 
 	iovec.iov_base = (void *)&buf_out;
diff --git a/exec/totemudpu.c b/exec/totemudpu.c
index 1b48d07..4a2f291 100644
--- a/exec/totemudpu.c
+++ b/exec/totemudpu.c
@@ -256,10 +256,8 @@ static inline void ucast_sendmsg (
 		msg_len,
 		buf_out,
 		&buf_out_len) != 0) {
-		/*
-		 * TODO: how to handle error here
-		 */
-		log_printf(LOGSYS_LEVEL_CRIT, "unable to crypt? now what?");
+		log_printf(LOGSYS_LEVEL_CRIT, "Error encrypting/signing packet (non-critical)");
+		return;
 	}
 
 	iovec.iov_base = (void *)buf_out;
@@ -319,10 +317,8 @@ static inline void mcast_sendmsg (
 		msg_len,
 		buf_out,
 		&buf_out_len) != 0) {
-		/*
-		 * TODO: how to handle error here
-		 */
-		log_printf(LOGSYS_LEVEL_CRIT, "Unable to crypt? now what?");
+		log_printf(LOGSYS_LEVEL_CRIT, "Error encrypting/signing packet (non-critical)");
+		return;
 	}
 
 	iovec.iov_base = (void *)buf_out;
-- 
1.7.7.6

_______________________________________________
discuss mailing list
discuss@xxxxxxxxxxxx
http://lists.corosync.org/mailman/listinfo/discuss