Re: [PATCH 07/11] votequorum: fix node check based on reconfig parameter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



ACK

Reviewed-By: Christine Caulfield <ccaulfie@xxxxxxxxxx>

On 02/03/12 11:02, Fabio M. Di Nitto wrote:
From: "Fabio M. Di Nitto"<fdinitto@xxxxxxxxxx>

Signed-off-by: Fabio M. Di Nitto<fdinitto@xxxxxxxxxx>
---
  exec/votequorum.c |   11 +++++------
  1 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/exec/votequorum.c b/exec/votequorum.c
index f26091b..9d489bb 100644
--- a/exec/votequorum.c
+++ b/exec/votequorum.c
@@ -1625,12 +1625,6 @@ static void message_handler_req_exec_votequorum_reconfigure (
  	log_printf(LOGSYS_LEVEL_DEBUG, "got reconfigure message from cluster node %u for %u",
  					nodeid, req_exec_quorum_reconfigure->nodeid);

-	node = find_node_by_nodeid(req_exec_quorum_reconfigure->nodeid);
-	if (!node) {
-		LEAVE();
-		return;
-	}
-
  	switch(req_exec_quorum_reconfigure->param)
  	{
  	case VOTEQUORUM_RECONFIG_PARAM_EXPECTED_VOTES:
@@ -1646,6 +1640,11 @@ static void message_handler_req_exec_votequorum_reconfigure (
  		break;

  	case VOTEQUORUM_RECONFIG_PARAM_NODE_VOTES:
+		node = find_node_by_nodeid(req_exec_quorum_reconfigure->nodeid);
+		if (!node) {
+			LEAVE();
+			return;
+		}
  		node->votes = req_exec_quorum_reconfigure->value;
  		recalculate_quorum(1, 0);  /* Allow decrease */
  		break;

_______________________________________________
discuss mailing list
discuss@xxxxxxxxxxxx
http://lists.corosync.org/mailman/listinfo/discuss


[Index of Archives]     [Linux Clusters]     [Corosync Project]     [Linux USB Devel]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Linux Kernel]     [Linux SCSI]     [X.Org]

  Powered by Linux