ACK
Reviewed-By: Christine Caulfield <ccaulfie@xxxxxxxxxx>
On 02/03/12 11:02, Fabio M. Di Nitto wrote:
From: "Fabio M. Di Nitto"<fdinitto@xxxxxxxxxx>
The problem here is that user expectations, when using both modes
at the same time, have not been set yet. There are 2/3 options
that need investigation.
Signed-off-by: Fabio M. Di Nitto<fdinitto@xxxxxxxxxx>
---
exec/votequorum.c | 14 ++++++++++++++
1 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/exec/votequorum.c b/exec/votequorum.c
index a4243ae..7ccd07e 100644
--- a/exec/votequorum.c
+++ b/exec/votequorum.c
@@ -925,6 +925,14 @@ static char *votequorum_readconfig_static(void)
return ((char *)"configuration error: quorum device is not compatible with auto_tie_breaker feature");
}
+ if ((have_qdevice)&& (wait_for_all)) {
+ /*
+ * TODO: disable compat for now. There is a problem on expected_votes vs local votes
+ * when starting qdevice on one node only that makes cluster quorate view not correct.
+ */
+ return ((char *)"configuration error: quorum device is not compatible with wait_for_all feature");
+ }
+
LEAVE();
return (NULL);
@@ -995,6 +1003,12 @@ static void votequorum_readconfig_dynamic(void)
update_qdevice_can_operate(0);
}
+ if ((have_qdevice)&& (wait_for_all)) {
+ log_printf(LOGSYS_LEVEL_CRIT, "configuration error: quorum.device is not compatible with wait_for_all");
+ log_printf(LOGSYS_LEVEL_CRIT, "disabling quorum device operations");
+ update_qdevice_can_operate(0);
+ }
+
/*
* if user specifies quorum.expected_votes + quorum.device but NOT the device.votes
* we don't know what the quorum device should vote.
_______________________________________________
discuss mailing list
discuss@xxxxxxxxxxxx
http://lists.corosync.org/mailman/listinfo/discuss
