Reviewed-by: Jan Friesse <jfriesse@xxxxxxxxxx>
Fabio M. Di Nitto napsal(a):
From: "Fabio M. Di Nitto" <fdinitto@xxxxxxxxxx>
this is a regression introduced by cb5fd775
when reading static config us->flags does not exists yet and therefor
setting it will cause a segfault.
Move the settings after cluster_node *us is created, with the long
term plan to simply kill the whole _static readconfig bits
in favour of dynamic (runtime changeable) bits.
Signed-off-by: Fabio M. Di Nitto <fdinitto@xxxxxxxxxx>
---
exec/votequorum.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/exec/votequorum.c b/exec/votequorum.c
index a5c9883..3e177e8 100644
--- a/exec/votequorum.c
+++ b/exec/votequorum.c
@@ -913,10 +913,6 @@ static char *votequorum_readconfig_static(void)
return ((char *)"configuration error: quorum device is not compatible with auto_tie_breaker feature");
}
- if (wait_for_all) {
- update_wait_for_all_status(1);
- }
-
LEAVE();
return (NULL);
@@ -1687,6 +1683,10 @@ static char *votequorum_exec_init_fn (struct corosync_api_v1 *api)
us->votes = 1;
us->flags |= NODE_FLAGS_FIRST;
+ if (wait_for_all) {
+ update_wait_for_all_status(1);
+ }
+
qdevice = allocate_node(NODEID_QDEVICE);
if (!qdevice) {
LEAVE();
_______________________________________________
discuss mailing list
discuss@xxxxxxxxxxxx
http://lists.corosync.org/mailman/listinfo/discuss
