Re: [PATCH 6/9] votequorum: fix possible memory corruption

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Reviewed-by: Steven Dake <sdake@xxxxxxxxxx>

On 02/07/2012 03:22 AM, Fabio M. Di Nitto wrote:
> From: "Fabio M. Di Nitto" <fdinitto@xxxxxxxxxx>
> 
> nodeid = 0 is a valide nodeid and node associated with it should
> not be freed
> 
> Signed-off-by: Fabio M. Di Nitto <fdinitto@xxxxxxxxxx>
> ---
> :100644 100644 5f37980... 9084b93... M	exec/votequorum.c
>  exec/votequorum.c |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/exec/votequorum.c b/exec/votequorum.c
> index 5f37980..9084b93 100644
> --- a/exec/votequorum.c
> +++ b/exec/votequorum.c
> @@ -1118,10 +1118,6 @@ static void message_handler_req_exec_votequorum_nodeinfo (
>  		recalculate_quorum(allow_downgrade, by_node);
>  	}
>  
> -	if (!nodeid) {
> -		free(node);
> -	}
> -
>  	if ((wait_for_all) &&
>  	    (!req_exec_quorum_nodeinfo->wait_for_all_status) &&
>  	    (req_exec_quorum_nodeinfo->quorate)) {

_______________________________________________
discuss mailing list
discuss@xxxxxxxxxxxx
http://lists.corosync.org/mailman/listinfo/discuss


[Index of Archives]     [Linux Clusters]     [Corosync Project]     [Linux USB Devel]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Linux Kernel]     [Linux SCSI]     [X.Org]

  Powered by Linux