Re: [PATCH 2/5] votequorum: fix possible string overflow (-1) in qdevice_register

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Reviewed-by: Jan Friesse <jfriesse@xxxxxxxxxx>

Fabio M. Di Nitto napsal(a):
From: "Fabio M. Di Nitto" <fdinitto@xxxxxxxxxx>

Signed-off-by: Fabio M. Di Nitto <fdinitto@xxxxxxxxxx>
---
 lib/votequorum.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/votequorum.c b/lib/votequorum.c
index 1b7edf4..2e810d8 100644
--- a/lib/votequorum.c
+++ b/lib/votequorum.c
@@ -541,7 +541,7 @@ cs_error_t votequorum_qdevice_register (
 	struct req_lib_votequorum_qdevice_register req_lib_votequorum_qdevice_register;
 	struct res_lib_votequorum_status res_lib_votequorum_status;
- if (strlen(name) > VOTEQUORUM_MAX_QDEVICE_NAME_LEN)
+	if (strlen(name) >= VOTEQUORUM_MAX_QDEVICE_NAME_LEN)
 		return CS_ERR_INVALID_PARAM;
error = hdb_error_to_cs(hdb_handle_get (&votequorum_handle_t_db, handle, (void *)&votequorum_inst));

_______________________________________________
discuss mailing list
discuss@xxxxxxxxxxxx
http://lists.corosync.org/mailman/listinfo/discuss


[Index of Archives]     [Linux Clusters]     [Corosync Project]     [Linux USB Devel]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Linux Kernel]     [Linux SCSI]     [X.Org]

  Powered by Linux