Re: [PATCH 2/9] quorumtool: drop redundant init calls to votequorum

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Reviewed-by: Steven Dake <sdake@xxxxxxxxxx>

On 01/12/2012 04:49 AM, Fabio M. Di Nitto wrote:
> From: "Fabio M. Di Nitto" <fdinitto@xxxxxxxxxx>
> 
> this is taken care of in initall
> 
> Signed-off-by: Fabio M. Di Nitto <fdinitto@xxxxxxxxxx>
> ---
> :100644 100644 c290815... 785ee7a... M	tools/corosync-quorumtool.c
>  tools/corosync-quorumtool.c |   10 ----------
>  1 files changed, 0 insertions(+), 10 deletions(-)
> 
> diff --git a/tools/corosync-quorumtool.c b/tools/corosync-quorumtool.c
> index c290815..785ee7a 100644
> --- a/tools/corosync-quorumtool.c
> +++ b/tools/corosync-quorumtool.c
> @@ -201,11 +201,6 @@ static int set_votes(uint32_t nodeid, int votes)
>  {
>  	int err;
>  
> -	if ((err=votequorum_initialize(&v_handle, &v_callbacks)) != CS_OK) {
> -		fprintf(stderr, "votequorum_initialize FAILED: %d, this is probably a configuration error\n", err);
> -		return err;
> -	}
> -
>  	if ((err=votequorum_setvotes(v_handle, nodeid, votes)) != CS_OK) {
>  		fprintf(stderr, "set votes FAILED: %d\n", err);
>  	}
> @@ -217,11 +212,6 @@ static int set_expected(int expected_votes)
>  {
>  	int err;
>  
> -	if ((err=votequorum_initialize(&v_handle, &v_callbacks)) != CS_OK) {
> -		fprintf(stderr, "votequorum_initialize FAILED: %d, this is probably a configuration error\n", err);
> -		return err;
> -	}
> -
>  	if ((err=votequorum_setexpected(v_handle, expected_votes)) != CS_OK) {
>  		fprintf(stderr, "set expected votes FAILED: %d\n", err);
>  	}

_______________________________________________
discuss mailing list
discuss@xxxxxxxxxxxx
http://lists.corosync.org/mailman/listinfo/discuss


[Index of Archives]     [Linux Clusters]     [Corosync Project]     [Linux USB Devel]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Linux Kernel]     [Linux SCSI]     [X.Org]

  Powered by Linux