Re: [PATCH 17/21] votequorum: fix another regressions introduced by 05b4e99a6e (dispatch notifications only once)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Reviewed-by: Steven Dake <sdake@xxxxxxxxxx>

On 01/10/2012 02:23 AM, Fabio M. Di Nitto wrote:
> From: "Fabio M. Di Nitto" <fdinitto@xxxxxxxxxx>
> 
> left_member_entries is never set when totem config change is regular.
> 
> Signed-off-by: Fabio M. Di Nitto <fdinitto@xxxxxxxxxx>
> ---
> :100644 100644 1e84df3... bbb067a... M	services/votequorum.c
>  services/votequorum.c |   10 ++++------
>  1 files changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/services/votequorum.c b/services/votequorum.c
> index 1e84df3..bbb067a 100644
> --- a/services/votequorum.c
> +++ b/services/votequorum.c
> @@ -982,10 +982,6 @@ static void quorum_confchg_fn (
>  
>  	ENTER();
>  
> -	if (configuration_type != TOTEM_CONFIGURATION_REGULAR) {
> -		return;
> -	}
> -
>  	if (member_list_entries > 1) {
>  		first_trans = 0;
>  	}
> @@ -1029,8 +1025,10 @@ static void quorum_confchg_fn (
>  
>  	memcpy(&quorum_ringid, ring_id, sizeof(*ring_id));
>  
> -	set_quorum(quorum_members, quorum_members_entries,
> -		   cluster_is_quorate, &quorum_ringid);
> +	if (configuration_type == TOTEM_CONFIGURATION_REGULAR) {
> +		set_quorum(quorum_members, quorum_members_entries,
> +			   cluster_is_quorate, &quorum_ringid);
> +	}
>  
>  	LEAVE();
>  }

_______________________________________________
discuss mailing list
discuss@xxxxxxxxxxxx
http://lists.corosync.org/mailman/listinfo/discuss


[Index of Archives]     [Linux Clusters]     [Corosync Project]     [Linux USB Devel]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Linux Kernel]     [Linux SCSI]     [X.Org]

  Powered by Linux