Re: [PATCH 2/4] Link totempg with icmap for rrp icmap calls

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I understand why you want to do this, but I'd rather you find a
different way to do it.

Ideally totempg.so would have no dependencies.  Instead you could do
something similar to how stats are collected now, or add a callback
registration into totempg.

Regards
-steve

On 01/06/2012 03:06 AM, Jan Friesse wrote:
> Signed-off-by: Jan Friesse <jfriesse@xxxxxxxxxx>
> ---
>  exec/Makefile.am |   11 ++++++++---
>  1 files changed, 8 insertions(+), 3 deletions(-)
> 
> diff --git a/exec/Makefile.am b/exec/Makefile.am
> index 7c63f9c..a77be17 100644
> --- a/exec/Makefile.am
> +++ b/exec/Makefile.am
> @@ -83,7 +83,7 @@ if BUILD_DARWIN
>  	$(CC) $(LDFLAGS) $(CFLAGS) -L$(top_builddir)/exec -llogsys -licmap -bundle -bind_at_load -bundle_loader ./corosync $^ -o $@
>  
>  libtotem_pg.so.$(SONAME): $(TOTEM_OBJS)
> -	$(CC) $(LDFLAGS) $(DARWIN_OPTS) $(TOTEM_OBJS) -o $@ -lpthread
> +	$(CC) $(LDFLAGS) $(DARWIN_OPTS) $(TOTEM_OBJS) -o $@ -lpthread -licmap
>  	ln -sf libtotem_pg.so.$(SONAME) libtotem_pg.so
>  	ln -sf libtotem_pg.so.$(SONAME) libtotem_pg.so.$(SOMAJOR)
>  
> @@ -104,7 +104,7 @@ if BUILD_SOLARIS
>  	$(LD) $(LDFLAGS) -G $^ -o $@
>  
>  libtotem_pg.so.$(SONAME): $(TOTEM_OBJS)
> -	$(LD) $(LDFLAGS) -G $(TOTEM_OBJS) -o $@ -lpthread
> +	$(LD) $(LDFLAGS) -G $(TOTEM_OBJS) -o $@ -lpthread -licmap
>  	ln -sf libtotem_pg.so.$(SONAME) libtotem_pg.so
>  	ln -sf libtotem_pg.so.$(SONAME) libtotem_pg.so.$(SOMAJOR)
>  
> @@ -113,6 +113,11 @@ liblogsys.so.$(SONAME): $(LOGSYS_OBJS)
>  	ln -sf liblogsys.so.$(SONAME) liblogsys.so
>  	ln -sf liblogsys.so.$(SONAME) liblogsys.so.$(SOMAJOR)
>  
> +libicmap.so.$(SONAME): $(ICMAP_OBJS)
> +	$(LD) $(LDFLAGS) -G $(ICMAP_OBJS) -o $@ -lpthread
> +	ln -sf libicmap.so.$(SONAME) libicmap.so
> +	ln -sf libicmap.so.$(SONAME) libicmap.so.$(SOMAJOR)
> +
>  else
>  
>  %.lcrso: %.o
> @@ -121,7 +126,7 @@ else
>  libtotem_pg.so.$(SONAME): $(TOTEM_OBJS)
>  	$(CC) -shared -o $@ \
>  		-Wl,-soname=libtotem_pg.so.$(SOMAJOR) \
> -		$(LDFLAGS) $^ $(nss_LIBS) $(rdmacm_LIBS) $(ibverbs_LIBS) -lpthread
> +		$(LDFLAGS) $^ $(nss_LIBS) $(rdmacm_LIBS) $(ibverbs_LIBS) -lpthread -licmap
>  	ln -sf libtotem_pg.so.$(SONAME) libtotem_pg.so
>  	ln -sf libtotem_pg.so.$(SONAME) libtotem_pg.so.$(SOMAJOR)
>  

_______________________________________________
discuss mailing list
discuss@xxxxxxxxxxxx
http://lists.corosync.org/mailman/listinfo/discuss


[Index of Archives]     [Linux Clusters]     [Corosync Project]     [Linux USB Devel]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Linux Kernel]     [Linux SCSI]     [X.Org]

  Powered by Linux