I'd think it would be helpful to print the internal config keys by default. Adding it as an option means the user has to find the option which seems unintuitive. On 01/06/2012 04:40 AM, Jan Friesse wrote: > Signed-off-by: Jan Friesse <jfriesse@xxxxxxxxxx> > --- > tools/corosync-cmapctl.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/tools/corosync-cmapctl.c b/tools/corosync-cmapctl.c > index 0c707a2..80d3fff 100644 > --- a/tools/corosync-cmapctl.c > +++ b/tools/corosync-cmapctl.c > @@ -288,7 +288,7 @@ static void print_iter(enum user_action action, cmap_handle_t handle, const char > > while ((err = cmap_iter_next(handle, iter_handle, key_name, &value_len, &type)) == CS_OK) { > if (action == ACTION_PRINT_DEFAULT && > - strncmp(key_name, "internal_configuration", strlen("internal_configuration") == 0)) > + strncmp(key_name, "internal_configuration", strlen("internal_configuration")) == 0) > continue; > print_key(handle, key_name, value_len, NULL, type); > } _______________________________________________ discuss mailing list discuss@xxxxxxxxxxxx http://lists.corosync.org/mailman/listinfo/discuss