Re: [PATCH] Fix some iterator based mem leaks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Reviewed-by: Steven Dake <sdake@xxxxxxxxxx>

On 01/04/2012 09:40 PM, Angus Salkeld wrote:
> Signed-off-by: Angus Salkeld <asalkeld@xxxxxxxxxx>
> ---
>  exec/ipc_glue.c    |    1 +
>  exec/totemconfig.c |    2 ++
>  2 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/exec/ipc_glue.c b/exec/ipc_glue.c
> index 4d40a08..4df5b6d 100644
> --- a/exec/ipc_glue.c
> +++ b/exec/ipc_glue.c
> @@ -453,6 +453,7 @@ static int32_t cs_ipcs_connection_closed (qb_ipcs_connection_t *c)
>  	while ((key_name = icmap_iter_next(iter, NULL, NULL)) != NULL) {
>  		icmap_delete(key_name);
>  	}
> +	icmap_iter_finalize(iter);
>  	free(cnx->icmap_path);
>  
>  	icmap_inc("runtie.connections.closed");
> diff --git a/exec/totemconfig.c b/exec/totemconfig.c
> index 1248a72..b0292b1 100644
> --- a/exec/totemconfig.c
> +++ b/exec/totemconfig.c
> @@ -300,10 +300,12 @@ extern int totem_config_read (
>  						str, 0);
>  			}
>  		}
> +		icmap_iter_finalize(member_iter);
>  
>  		totem_config->interfaces[ringnumber].member_count = member_count;
>  		totem_config->interface_count++;
>  	}
> +	icmap_iter_finalize(iter);
>  
>  	totem_config->transport_number = TOTEM_TRANSPORT_UDP;
>  	if (icmap_get_string("totem.transport", &str) == CS_OK) {

_______________________________________________
discuss mailing list
discuss@xxxxxxxxxxxx
http://lists.corosync.org/mailman/listinfo/discuss


[Index of Archives]     [Linux Clusters]     [Corosync Project]     [Linux USB Devel]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Linux Kernel]     [Linux SCSI]     [X.Org]

  Powered by Linux