Re: [PATCH 5/7] don't log an error if exiting with 0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/21/2011 12:57 AM, Angus Salkeld wrote:
> Signed-off-by: Angus Salkeld <asalkeld@xxxxxxxxxx>
> ---
>  exec/util.c |   10 +++++++---
>  1 files changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/exec/util.c b/exec/util.c
> index 16ba3c8..d6b4e79 100644
> --- a/exec/util.c
> +++ b/exec/util.c
> @@ -140,9 +140,13 @@ void _corosync_exit_error (
>  void _corosync_exit_error (
>  	enum e_ais_done err, const char *file, unsigned int line)
>  {
> -	log_printf (LOGSYS_LEVEL_ERROR, "Corosync Cluster Engine exiting "
> -		"with status %d at %s:%u.\n", err, file, line);
> -
> +	if (err == AIS_DONE_EXIT) {
> +		log_printf (LOGSYS_LEVEL_NOTICE, "Corosync Cluster Engine exiting "
> +			"with status %d at %s:%u.\n", err, file, line);
> +	} else {
> +		log_printf (LOGSYS_LEVEL_ERROR, "Corosync Cluster Engine exiting "
> +			"with status %d at %s:%u.\n", err, file, line);
> +	}

Reviewed-by: Steven Dake <sdake@xxxxxxxxxx>

Looks good.  Another option is "Corosync Cluster engine exiting normally."

Regards
-steve

>  	qb_log_fini();
>  	exit (err);
>  }

_______________________________________________
discuss mailing list
discuss@xxxxxxxxxxxx
http://lists.corosync.org/mailman/listinfo/discuss


[Index of Archives]     [Linux Clusters]     [Corosync Project]     [Linux USB Devel]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Linux Kernel]     [Linux SCSI]     [X.Org]

  Powered by Linux