-------- Original Message --------
Subject: fence-agent : ipmilan : power_wait : missing in ipmi_off.
Date: Fri, 03 Feb 2012 15:20:47 +0100 (CET)
From: Alexandre DERUMIER <aderumier@xxxxxxxxx>
To: ccaulfie@xxxxxxxxxx
Hi,
I'm working to implement a redhat cluster and I think I found a bug in
ipmilan.c
On this commit:
fence-agents: Add power_wait to fence_ipmilan
http://git.fedorahosted.org/git/?p=fence-agents.git;a=commitdiff;h=7d53eb8ab06a8713d2b52500da741b6170fbfc91
in ipmi_off , the sleep(2) is still hardcorded
I think It must replace with sleep(ipmi->i_power_wait), like ipmi_on ?
index 52be371..46814a8 100644
--- a/fence/agents/ipmilan/ipmilan.c
+++ b/fence/agents/ipmilan/ipmilan.c
@@ -473,7 +473,7 @@ ipmi_off(struct ipmi *ipmi)
if (ret != 0)
return ret;
- sleep(2);
+ sleep(ipmi->i_power_wait);
--retries;
ret = ipmi_op(ipmi, ST_STATUS, power_status);
What do you thinks about it ?
Best Regards,
Alexandre Derumier
System Engineer
aderumier@xxxxxxxxx
--
Linux-cluster mailing list
Linux-cluster@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/linux-cluster
