On Mon, Apr 23, 2007 at 11:15:22AM +0200, Simone Gotti wrote: > Hi, > > like discussed with lon on IRC I'm trying to add to rgmanager the > ability to freeze a service. I worked on it in these days and did an > example patch. Here is how I think what a "freeze" can be and, of > course, it can be implemented in many other ways so it's only an > example. Hi, couple of comments - (1) s/freezed/frozen/ig :) (2) svc_status_inquiry shouldn't call rg_lock(); you should use get_rg_state_local() instead of rg_lock/get_rg_state/rg_unlock Note that svc_status_inquiry isn't even used yet, so the behavior might change at a later date ;) (3.a) Warning: The addition of rs_flags to rg_state_t will break compatibility with existing software (which is fine in -HEAD). It would be easier to cope with this change (that is- make upgrades from old->new work) if you added the rs_flags field after the rs_transition field. (3.b) If you don't want to do that, then you need to add another 32-bits worth of data (could be just a "pad" field) before rs_transition because the kernel on ia64 machines will complain if they read a 64-bit int and it's not aligned on a 64-bit boundary. Aside from that, it looks like you got it right for what you wanted it to do. I can fix (1) (language stuff) if you fix (2) and (3). -- Lon -- Lon Hohberger - Software Engineer - Red Hat, Inc. -- Linux-cluster mailing list Linux-cluster@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/linux-cluster
