Re: [PATCH] qdisk: fix crash or wrong behavior if "qdisk_read" returns an error.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2007-01-10 at 17:08 +0100, Simone Gotti wrote:
> In qdisk/main.c:read_node_blocks if the call to "qdisk_read" returns an
> error, the cycle isn't interrupted and the call swab_status_block_t will
> make qdiskd crash or report bad node id, master status etc.... This will
> probably (not reproduced) cause strange behavior like this node trying
> to kill the others that are working correctly.
> 
> I putted a "continue" to skip the cycle after the error. As if nothing
> about the node can be read it's better to not change the current
> informations.
> 
> I hope the patch is correct.

It looks right.

-- Lon

Attachment: signature.asc
Description: This is a digitally signed message part

--
Linux-cluster mailing list
Linux-cluster@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/linux-cluster

[Index of Archives]     [Corosync Cluster Engine]     [GFS]     [Linux Virtualization]     [Centos Virtualization]     [Centos]     [Linux RAID]     [Fedora Users]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite Camping]

  Powered by Linux