Re: [-mm patch] drivers/dlm/: possible cleanups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Nov 04, 2005 at 01:06:40PM +0100, Adrian Bunk wrote:
> This patch contains the following possible cleanups:
> - every file should #include the headers containing the prototypes for
>   it's global functions

Including unnecessary headers doesn't sound right.

> - make needlessly global functions static
> - #if 0 the following unused global functions:
>   - device.c: dlm_device_free_devices
>   - lock.c: dlm_remove_from_waiters
>   - lockspace.c: dlm_find_lockspace_name

I've removed the unused functions and added the statics.

Thanks,
Dave

--

Linux-cluster@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/linux-cluster

[Index of Archives]     [Corosync Cluster Engine]     [GFS]     [Linux Virtualization]     [Centos Virtualization]     [Centos]     [Linux RAID]     [Fedora Users]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite Camping]

  Powered by Linux