On Wed, Aug 10, 2005 at 10:40:37AM +0300, Pekka J Enberg wrote:
> Hi David,
>
> >+ return -EINVAL;
> >+ if (!access_ok(VERIFY_WRITE, buf, size))
> >+ return -EFAULT;
> >+
> >+ if (!(file->f_flags & O_LARGEFILE)) {
> >+ if (*offset >= 0x7FFFFFFFull)
> >+ return -EFBIG;
> >+ if (*offset + size > 0x7FFFFFFFull)
> >+ size = 0x7FFFFFFFull - *offset;
>
> Please use a constant instead for 0x7FFFFFFFull. (Appears in various other
> places as well.)
In fact this very much looks like it's duplicating generic_write_checks().
Folks, please use common code.
--
Linux-cluster@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/linux-cluster
